[vlc-devel] [PATCH v2 02/18] Rename android/thread.c to posix/thread_nocancel.c

[Dennis Hamester]

This change was discussed and agreed upon with Thomas on irc.

Are you referring to my wording here or about supporting a posix'ish
platform without cancellation support? If I remember correctly, _you_
implemented the work-around with futexes for missing cancel in Android.


On 03/13/2017 08:07 PM, Rémi Denis-Courmont wrote:
> Le maanantaina 13. maaliskuuta 2017, 12.36.48 EET Dennis Hamester a écrit :
>> From: Dennis Hamester <dennis.hamester at startmail.com>
>>
>> The existing thread implementation for systems, which lack proper
>> pthread cancel support, can be used not just on Android but other
>> platforms as well (NaCl for example).
>> ---
>>  src/Makefile.am                                   | 2 +-
>>  src/{android/thread.c => posix/thread_nocancel.c} | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>  rename src/{android/thread.c => posix/thread_nocancel.c} (99%)
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index 1e0e70fa86..72227dc65c 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -391,7 +391,7 @@ if HAVE_ANDROID
>>  libvlccore_la_SOURCES += \
>>  	android/error.c \
>>  	android/specific.c \
>> -	android/thread.c \
>> +	posix/thread_nocancel.c \
> 
> There is no such thing as POSIX without thread cancellation. This is very 
> misleading. No thanks.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170313/f2fd7669/attachment.sig>