[vlc-devel] [PATCH v2 10/18] keystore: nacl: Include fcntl.h for flock

[Dennis Hamester]

On 13.03.2017 20:18, Rémi Denis-Courmont wrote:
> Le maanantaina 13. maaliskuuta 2017, 12.36.56 EET Dennis Hamester a écrit :
>> From: Julian Scheel <julian at jusst.de>
>>
>> The native client environment provides flock and it's defines in
>> glibc-compat thorugh fcntl.h guarded by __BSD_VISIBLE. Include it as
>> needed.
> 
> If newlib follows the same conventions as glibc, the user is supposed to 
> define single underscore macros and let the internal headers define the double 
> underscore macros.
> 
> So this looks very suspicious.
> 

The problem here is, that the flock as a function exists on nacl (you
can link to it, an thus AC_CHECK_FUNCS is happy). But newlib defines the
various flags (LOCK_*) only on BSD.

We're open to suggestions on how to handle this.

-- 
Dennis Hamester
Software Development
-----------------------------------
jusst technologies GmbH

tel: +49 (0)40 1800 86 75
fax: +49 (0)40 1800 86 76
mail: dhamester at jusst.de

Ohlstedter Straße 12
22397 Hamburg
Deutschland

www.jusst.de

Vertretungsberechtigte Geschäftsführer: Julian Scheel, Wolfgang Scheel
Registergericht: Amtsgericht Hamburg
Registernummer: HRB 94300
USt-ID-Nr.: DE 243309917

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170314/794e96c8/attachment.sig>