[vlc-devel] [RFC PATCH 2/2] lib/video: toggle teletext from libvlc_video_set_teletext

[Rémi Denis-Courmont]

Le tiistaina 14. maaliskuuta 2017, 10.44.28 EET Thomas Guillem a écrit :
> Either we say in the documentation, that teletext should be enabled via
> libvlc_toggle_teletext() before/after setting a page or we enable teletext
> directly from this function.
> 
> I don't like the libvlc_toggle_teletext() function, I would have preferred a
> set_enabled(bool) function.

Yes, toggle functions are daft. But I´m not exactly surprised considering when 
and by whom it was added.

> For me, we have three choices:
> 
>  - What is done in this current commit: enable/disable teletext according to
> the page argument.

Makes sense.

>  - Improve documentation, tell to use libvlc_toggle_teletext().

No. That should be deprecated.

>  - Improve documentation, tell to use a newly created function
>    libvlc_video_set_teletext_enabled(bool), deprecate the old one.

That´s hardly better than toggle. You can´t atomically enable and set the 
page.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/