[vlc-devel] [PATCH 2/3] demux/playlist/itml: remove unnecessary branch

Filip Roséen filip at atch.se
Wed Mar 15 10:10:13 CET 2017


An xml-document containing a tag without a name is ill-formed, so this
case will never happen in practice (as the xml-reader will error out
before).

However, if it for some reason would happen, it will be handled due to
the fact that there will not be any handler matching "".
---
 modules/demux/playlist/itml.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/modules/demux/playlist/itml.c b/modules/demux/playlist/itml.c
index c77cbaa5a8..2c9a0b72fe 100644
--- a/modules/demux/playlist/itml.c
+++ b/modules/demux/playlist/itml.c
@@ -179,11 +179,6 @@ static bool parse_dict( demux_t *p_demux, input_item_node_t *p_input_node,
         {
         /*  element start tag  */
         case XML_READER_STARTELEM:
-            if( !*node )
-            {
-                msg_Err( p_demux, "invalid XML stream" );
-                goto end;
-            }
             /* choose handler */
             for( p_handler = p_handlers;
                      p_handler->name && strcmp( node, p_handler->name );
-- 
2.12.0


More information about the vlc-devel mailing list