[vlc-devel] [PATCH 1/2] configure: allow toggling of -Wl, -z, defs and -no-undefined

[Filip Roséen]

Hi Rémi,

On 2017-03-15 14:51, Rémi Denis-Courmont wrote:

> On March 15, 2017 11:10:27 AM GMT+02:00, "Filip Roséen" <filip at atch.se> wrote:
> >There are cases where it is annoying to build VLC with this
> >restriction as you would like to use symbols that are simply not
> >present (in terms of definition) when things are being built.
> >
> >SUMMARY:
> >
> > - "-Wl,-z,defs" is now opt-out + automatic detection
> > - "-no-undefined" is now opt-out
> >
> >Both options are governed by a new configure flag,
> >"--{enable,disable}-no-undefined-symbols" as they are tightly coupled.
> >

> I added this because I am fed up with devs not checking their
> dependencies correctly, breaking my and Debian builds frequently.

I certainly understand the frustration of waking up early to work on
vlc, only to realize that things are broken after a fresh `git pull`.

However, I do not see that as a compelling argument for not enabling
the functionality that this patch introduce, especially given that the
check for undefined-reference's are opt-**out** and not opt-**in**.

> So obviously, I am very much against this change. This removes a
> very useful build-time diagnostic and WILL cause more build breaks.

The check to verify that no undefined symbols are present in
*vlc-objects* are very nice to have per default, and I salute you for
the addition, but I do not see how this patch contradicts that
statement nor functionality.

Best Regards,\
Filip
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170315/38c509ad/attachment.html>