[vlc-devel] [PATCH v2 08/18] newlib/nacl: Include sys/uio for iovec

[Dennis Hamester]

On 15.03.2017 15:06, Rémi Denis-Courmont wrote:
> On mercredi 15 mars 2017 11:26:51 EET Dennis Hamester wrote:
>> On 13.03.2017 20:17, Rémi Denis-Courmont wrote:
>>> Le maanantaina 13. maaliskuuta 2017, 12.36.54 EET Dennis Hamester a écrit 
> :
>>>> From: Julian Scheel <julian at jusst.de>
>>>>
>>>> The iovec struct is defined in a dedicated header for newlib.
>>>
>>> Which header? <sys/uio.h> is the standard header for iovec AFAIK.
>>
>> Yes, that is the correct header, but very few users of iovec in VLC
>> actually include it.
> 
> Most headers don' t need iovec to be anything more than an unspecified struct.

I wasn't talking about headers. Take modules/access/rtp/input.c as an
example, struct iovec is clearly used there but sys/uio.h is not included.

That's just one of many examples. Compare `grep -r "struct iovec"` to
`grep -r "sys/uio.h"`.

> 
> vlc_fixups.h is really not the place to fix programming errors in the VLC code 
> base, IMO.

That's why I would like to get rid of the #include <sys/uio.h> in the
patch and just define IOV_MAX.

> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 

-- 
Dennis Hamester
Software Development
-----------------------------------
jusst technologies GmbH

tel: +49 (0)40 1800 86 75
fax: +49 (0)40 1800 86 76
mail: dhamester at jusst.de

Ohlstedter Straße 12
22397 Hamburg
Deutschland

www.jusst.de

Vertretungsberechtigte Geschäftsführer: Julian Scheel, Wolfgang Scheel
Registergericht: Amtsgericht Hamburg
Registernummer: HRB 94300
USt-ID-Nr.: DE 243309917

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170315/96686d32/attachment.sig>