[vlc-devel] [PATCH 1/2] tests: Do not use -static for hxxx on darwin

Marvin Scholz epirat07 at gmail.com
Thu Mar 16 12:20:35 CET 2017


---

I don't know why this was added or what it is for, but it causes the
resulting binary not running due to failure loading libs, therefore
causing a test failure.

If -static is actually important here and the failure is a result of a problem
elsewhere, please let me know. This was just the easiest way I found to get the
hxxx test binary running.

 test/Makefile.am | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/Makefile.am b/test/Makefile.am
index 8d4ae30..03dacc4 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -124,7 +124,9 @@ test_src_interface_dialog_SOURCES = src/interface/dialog.c
 test_src_interface_dialog_LDADD = $(LIBVLCCORE) $(LIBVLC)
 test_modules_packetizer_hxxx_SOURCES = modules/packetizer/hxxx.c
 test_modules_packetizer_hxxx_LDADD = $(LIBVLC)
+if !HAVE_DARWIN
 test_modules_packetizer_hxxx_LDFLAGS = -no-install -static # WTF
+endif
 test_modules_keystore_SOURCES = modules/keystore/test.c
 test_modules_keystore_LDADD = $(LIBVLCCORE) $(LIBVLC)
 test_modules_tls_SOURCES = modules/misc/tls.c
-- 
2.10.1 (Apple Git-78)



More information about the vlc-devel mailing list