[vlc-devel] [PATCH 8/8] gui/qt: remove unnecessary forward declarations in global scope
Filip Roséen
filip at atch.se
Mon Mar 20 13:41:58 CET 2017
Given that these identifiers are only necessary for the data-member
declarations within struct intf_sys_t, it is preferred to simply use
elaborated type specifiers (the semantics are equivalent).
---
modules/gui/qt/qt.hpp | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/modules/gui/qt/qt.hpp b/modules/gui/qt/qt.hpp
index 15dea9fe6c..569945ebb0 100644
--- a/modules/gui/qt/qt.hpp
+++ b/modules/gui/qt/qt.hpp
@@ -68,22 +68,14 @@ enum{
NOTIFICATION_ALWAYS = 2,
};
-class QVLCApp;
-class MainInterface;
-class QSettings;
-class PLModel;
-
struct intf_sys_t
{
vlc_thread_t thread;
- QVLCApp *p_app; /* Main Qt Application */
-
- MainInterface *p_mi; /* Main Interface, NULL if DialogProvider Mode */
-
- QSettings *mainSettings; /* Qt State settings not messing main VLC ones */
-
- PLModel *pl_model;
+ class QVLCApp *p_app; /* Main Qt Application */
+ class MainInterface *p_mi; /* Main Interface, NULL if DialogProvider Mode */
+ class QSettings *mainSettings; /* Qt State settings not messing main VLC ones */
+ class PLModel *pl_model;
QString filepath; /* Last path used in dialogs */
--
2.12.0
More information about the vlc-devel
mailing list