[vlc-devel] [PATCH] demux/ty: Demux: replace if-else with switch

[Hugo Beauzée-Luyssen]

On Mon, Mar 20, 2017, at 02:46 PM, Filip Roséen wrote:
> Hi Francois,
> 
> On 2017-03-20 14:37, Francois Cartegnie wrote:
> 
> > Le 20/03/2017 à 14:26, Filip Roséen a écrit :
> > > A switch should be easier to maintain, while also improving
> > > readability.
> > 
> > 
> > > +        case 0x01: /* closed caption */
> > > +        case 0x02: /* XDS */
> > > +            DemuxRecCc( p_demux, p_rec, p_block_in );
> > > +            break;
> > 
> > Misleading incorrect attribution of comments to single values.
> 
> Thank you for pointing that out, I misread the previous comments and
> thought they applied to each of the two values seperately (which I
> know understand is of course not the case).
> 
> See attached patch for a fixup (since the patch got applied while you
> were replying).
> 
> All the best,\
> Filip
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> Email had 1 attachment:
> + 0001-demux-ty-Demux-fix-comment-related-to-closed-caption.patch
>   1k (text/x-diff)

Fixup applied, sorry for overlooking that while applying the patchset.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr