[vlc-devel] [PATCH v3 05/19] nacl: Add new system type

[Julian Scheel]

On 21.03.2017 20:52, Rémi Denis-Courmont wrote:
> Le maanantaina 20. maaliskuuta 2017, 17.57.22 EET Dennis Hamester a écrit :
>> diff --git a/src/nacl/plugin.c b/src/nacl/plugin.c
>> new file mode 100644
>> index 0000000000..c4cb50f76d
>> --- /dev/null
>> +++ b/src/nacl/plugin.c
>> @@ -0,0 +1,46 @@
>> +/**************************************************************************
>> *** + * plugin.c : Empty stubs for NaCl, which does not allow dynamic
>> loading +
>> ***************************************************************************
>> ** + * Copyright (C) 2017 VLC authors and VideoLAN
>> + *
>> + * Authors: Julian Scheel <julian at jusst.de>
>> + *
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Lesser General Public License as published by
>> + * the Free Software Foundation; either version 2.1 of the License, or + *
>> (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU Lesser General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU Lesser General Public License
>> + * along with this program; if not, write to the Free Software Foundation,
>> + * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. +
>> ***************************************************************************
>> **/ +
>> +#include <vlc_common.h>
>> +#include "modules/modules.h"
>> +
>> +int module_Load (vlc_object_t *p_this, const char *path,
>> +                 module_handle_t *p_handle, bool lazy)
>> +{
>> +    VLC_UNUSED(p_this);
>> +    VLC_UNUSED(path);
>> +    VLC_UNUSED(p_handle);
>> +    VLC_UNUSED(lazy);
>> +    return -1;
>> +}
>> +
>> +void module_Unload(module_handle_t handle)
>> +{
>> +    VLC_UNUSED(handle);
>> +}
>> +
>> +void *module_Lookup(module_handle_t handle, const char *psz_function)
>> +{
>> +    VLC_UNUSED(handle);
>> +    VLC_UNUSED(psz_function);
>> +    return NULL;
>> +}
>
> What´s the point? Those functions are not called in builds without plugin
> support.

Ack, not needed, removed.