[vlc-devel] [PATCH 6/7] preparser: post-pone event until after art fetching is complete

[Hugo Beauzée-Luyssen]

Hi Rémi and Filip,

On Wed, Mar 22, 2017, at 06:53 PM, Filip Roséen wrote:
> Hi Rémi,
> 
> I will let Hugo answer your remarks in detail as the patch might have
> been written by me, but the rationale for it is his (including the
> first part of the commit message).
> 

Currently when calling libvlc_media_parse_with_options, it's possible to
ask for art fetching. It's actually the only way I know of to fetch
media art using libvlc.
However, the event sent in return gets sent as soon as the preparsing is
finished, regardless of the art fetching. This is fine when no art
fetching is required, but not when the user actually queries art.
There are alternatives, such as monitoring the media meta, and wait for
ArtworkUrl to change, but if this takes too long, or fails for whatever
reason, there is no notification being sent.
I do agree that it might be extremely slow if libvlc_media_fetch_network
is specified, but then I'd say that it's the responsibility of the
caller to take it into account, by specifying a reasonable timeout.

Regards,


-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr