[vlc-devel] [PATCH 1/6] input/stream: add stream_extractor_AttachedParsed

Filip Roséen filip at atch.se
Tue Mar 28 19:52:55 CEST 2017


Hi Rémi,

On 2017-03-28 20:51, Rémi Denis-Courmont wrote:

> Le perjantaina 17. maaliskuuta 2017, 3.22.31 EEST Filip Roséen a écrit :
> > This function will be used by entities who would otherwise have to
> > manually attach stream-extractors to a stream through use of
> > mrl_FragmentSplit and repeated use of vlc_stream_extractor_Attach.
> > 
> > As this handles both, it will be prevent reimplementing the same
> > functionality for cases where this is required.
> > ---
> >  src/input/stream.h           | 26 ++++++++++++++++++++++++++
> >  src/input/stream_extractor.c | 35 +++++++++++++++++++++++++++++++++++
> >  2 files changed, 61 insertions(+)
> > 
> > diff --git a/src/input/stream.h b/src/input/stream.h
> > index 5db5732f40..2f5ca8b9b7 100644
> > --- a/src/input/stream.h
> > +++ b/src/input/stream.h
> > @@ -53,6 +53,32 @@ stream_t *stream_FilterAutoNew( stream_t *source )
> > VLC_USED; */
> >  stream_t *stream_FilterChainNew( stream_t *p_source, const char *psz_chain
> > );
> > 
> > +/**
> > + * This function will parse the passed data, and try to attach
> > + * stream-extractors for each specified entity as per \ref mrl,
> 
> For the umpteenth time, people, please check what your documentation looks 
> like in Doxygen. Such a long first paragraph is *not* good.

Oh my, and I am usually one of those who cringe a little when
stumbling across (to me) weird formatting. I should have
double-checked that, thanks for pointing it out.

Best Regards,\
Filip Roséen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170328/8162a10e/attachment.html>


More information about the vlc-devel mailing list