[vlc-devel] [PATCH] packetizer: dts: workaround incorrect FSIZE (fix #18166)

[Thomas Guillem]

On Tue, Mar 28, 2017, at 22:03, Francois Cartegnie wrote:
> Le 28/03/2017 à 21:57, Rémi Denis-Courmont a écrit :
> 
> >>              p_sys->i_input_size = p_sys->i_next_offset
> >> +                                /* Even frame size is likely incorrect
> >> FSIZE. +                                 * Sync minus one byte, we can
> >> always sync 1 byte further */ = (p_sys->dts.i_frame_size % 2) ?
> >> p_sys->dts.i_frame_size - 1
> >>                                                                  : p_sys->dt
> >>                                                                  : s.i_frame
> >>                                                                  : _size;
> >>
> >>              p_sys->i_state = STATE_NEXT_SYNC;
> > 
> > I am not sure why you send a commenting-only patch for review, TBH.
> 
> Forgot to squash commits.
> That's the 2 following lines.
> 

OK with this patch. This won't hurt much, since size will be even in
most case.
Just nitpicking, I would prefer to have the comment before
p_sys->i_input_size = ...

> Francois
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel