[vlc-devel] [PATCH] meta: merge only meta data not previously inserted

[Filip Roséen]

Hi Jean-Baptist and Lukas,

On 2017-03-29 08:35, Jean-Baptiste Kempf wrote:

> I did not give any suggestion at my first email, because, tbh, I
> don't know.
> 
> We're in the case, where the playlist metadata should override the input
> metadata, which is a unique case.
> 
> But yes, it's an annoying case that we need to fix.

The only real way of fixing the issue would be to not discard already
gathered metadata when a new source is queiried, but to save all
metadata present and then have a priority score denoting which one
that should be displayed (no matter if it was the first source
queried, or not).

We can default to showing the last written value, while still
allowing:

 1. metadata from other sources than the most recently queried to be
    viewed, and;

 2. the user can explicitly state that some source has higher priority
    than another (no matter the order of writes).

As the order in which we query metadata is implementation-defined
(from the user's perspective), simply changing the way we merge
metadata is not the path to walk in my opinion.

The above would also greatly gain the user-experience as we would no
longer discard metadata when the same key has data in different
sources.

> On Tue, 28 Mar 2017, at 23:39, Lukas Solanka wrote:
> 
> > Any suggestions on how to tackle #4143? I had another look at the core
> > and it looks to me that various demuxers, codecs, etc. contribute to
> > the metadata, without any particular rules. If the flac file does not
> > contain any embedded cue sheet this will overwrite any demuxed cue
> > meta added to the playlist previously.

Best Regards,\
Filip Roséen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170329/61548203/attachment.html>