[vlc-devel] [PATCH 5/7] playlist: fix deadlock on destruction while preparser adds items to playlist

[Filip Roséen]

Hi Rémi,

On 2017-03-29 21:23, Rémi Denis-Courmont wrote:

> Le keskiviikkona 29. maaliskuuta 2017, 19.41.53 EEST Filip Roséen a écrit :
> > Hi Rémi,
> > 
> > On 2017-03-29 20:34, Rémi Denis-Courmont wrote:
> > > As ALREADY NOTED; this cannot possibly fix the bug in question.
> > 
> > It fixes the issue described in ticket [#18151][1], which you closed as a
> > duplicate of [#17652][2]. I would be interested to see know how #18151 is
> > not fixed, as I did extensive testing and a lot of proof-reading to
> > inspect the relevant paths taken.
> 
> I would be interested to know how a lock inversion can be fixed while not 
> settling for one lock order or the other, nor eliminating the code paths 
> leading to either orders.

As stated, you are the one who closed `#18151` as a duplicate of
`#17652`; the ticket description for the former in detail describe
what lock is being taken, and why it deadlocks.

> That it can´t be reproduced with the Qt, maybe. However that it is fixed 
> sounds logically impossible.

This was extensively tested with various setups, with and without
*Qt* (as well as with other interfaces just for good measure). This
has little to nothing to do with the interface used as it was very
easily reproducible "without" (`-Idummy`) any interface at all.. as
the problem lies in how clean-up is being done (which previously
raced, as described in `#18151`).

/F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170329/e45bd411/attachment.html>