[vlc-devel] [PATCH] win32: do not load wininet.dll on startup, it's not a Known DLL

Jean-Baptiste Kempf jb at videolan.org
Wed Mar 29 22:04:49 CEST 2017


Hello,

On Wed, 29 Mar 2017, at 21:44, RĂ©mi Denis-Courmont wrote:
> Filip and I objected to dynamically loading DLL - the patch at the top of
> this thread - because it adds complexity ("onion") and fixes literally nothing
> as far as VLC is concerned.

I disagree.

> What is the concern with the manifest being inside or outside the
> executable?

If it is inside, you cannot modify it easily, and therefore cannot
override a Known DLL loading, like it was done with the pspapi.dll case.

Unless you can forge the VideoLAN or Microsoft signature.

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734


More information about the vlc-devel mailing list