[vlc-devel] [PATCH 6/7] preparser: post-pone event until after art fetching is complete

[Hugo Beauzée-Luyssen]

On Wed, Mar 29, 2017, at 09:14 PM, Rémi Denis-Courmont wrote:
> Le perjantaina 24. maaliskuuta 2017, 3.28.33 EEST Filip Roséen a écrit :
> > Since one can request art to be fetched through
> > libvlc_media_parse_with_options, one would expect the event
> > originating from this request to be sent upon the completion of all
> > requested operations (not just the preparsing). The alternative would
> > be to monitor the libvlc_MediaMetaChanged, hoping for an artwork URL
> > change, but this can't account for error nor timeout.
> 
> I still don´t agree for the same reasons as before.
> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

Since there has been a patch adding an event which you refused, a new
patch that doesn't add an event but signals the completion later that
you disagree with, I can only assume that what you want is to add a
state to libvlc_media_parsed_status_t in order to signal metadata are
available, and that at a later time, art is available.
I don't think it's a good idea to do so, since this would either mean:
- We use the same libvlc_media_parsed_status_failed/timeout for either
art and metadata. The libvlc user could keep tracks of which event gets
received, but I believe the states should be managed by libvlc
- We end up having a libvlc_media_(parsed|art)_status_(failed|timeout),
but that's inherently the same as duplicating the events.

Plus, it's still possible to monitor the libvlc_MediaMetaChanged event
to have a fast notification of changing meta, while relying on the
libvlc_MediaParsedChanged event to signal completion. The said
completion is now coherent with the parameters provided to
libvlc_media_parse_with_options, which IMHO is the expected behavior.

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr