[vlc-devel] [PATCH 0/8] Early DXVA creation

[Steve Lhomme]

On Fri, May 5, 2017 at 10:34 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le perjantaina 5. toukokuuta 2017, 22.08.37 EEST Steve Lhomme a écrit :
>> On Fri, May 5, 2017 at 6:52 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> > Le perjantaina 5. toukokuuta 2017, 18.42.16 EEST Steve Lhomme a écrit :
>> >> To do this, I try to create the vout and the va module before actually
>> >> creating the libavcodec instance.
>> >
>> > This violates the libavcodec API and cannot work properly .
>>
>> How does this violate the API ? Where does it say you cannot create
>> the VA filter before it's being requested ?
>
> Either you need get_format() and this patch does not make much sense. Or you
> don´t, and the code ought to be simplified a LOT.

The old way of doing things is still called. It will call get_format.
And either we messed up and configured our thing wrong, we will issue
a format change and get back on our feet (and still keep a single
thread). Or we got it right and nothing will happen from this "new
format" notification.

> With that said, Libavcodec won´t tell what the supported output formats are
> earlier, so we seem to be in the first case.
>
> --
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel