[vlc-devel] [PATCH] Directory: ignore xml files

[Filip Roséen]

Hi j-b,

On 2017-05-19 15:06, Jean-Baptiste Kempf wrote:

> XML is way too vague
> ---
>  modules/demux/directory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/demux/directory.c b/modules/demux/directory.c
> index ffc87b0fd6..88d42fdf91 100644
> --- a/modules/demux/directory.c
> +++ b/modules/demux/directory.c
> @@ -121,7 +121,7 @@ vlc_module_begin()
>          change_string_list( psz_recursive_list, psz_recursive_list_text )
>      add_string( "ignore-filetypes", "m3u,db,nfo,ini,jpg,jpeg,ljpg,gif,png,pgm,"
>                  "pgmyuv,pbm,pam,tga,bmp,pnm,xpm,xcf,pcx,tif,tiff,lbm,sfv,txt,"
> -                "sub,idx,srt,cue,ssa",
> +                "sub,idx,srt,cue,ssa,xml",
>                  IGNORE_TEXT, IGNORE_LONGTEXT, false )
>      add_bool( "show-hiddenfiles", false,
>                SHOW_HIDDENFILES_TEXT, SHOW_HIDDENFILES_LONGTEXT, false )
> -- 

As written in `#videolan` at `freenode`, this would break playback for
[iTunes Library Files][1] ([demux/playlist/itml.c][2]) when opening a
directory (as they would no longer be added to the playlist).

One could, potentially, ignore files (remove from playlist) for which
*preparsing* (if any) fails for a certain set of file-extensions, but
it will probably lead to users being confused about what is happening
to the state of the playlist (as they will most likely be able to see
the items disappear in real time).

Having it as an opt-in option might be a solution, but I am not too
sure. Personally, I am semi-against making decisions based on the
file-extension alone (as it does not necessarily reflect the true
contents of the file). I do however see how users can find the
`--hidden-filetypes` option useful.

Best Regards,\
Filip

[1]: https://support.apple.com/en-us/HT201610
[2]: http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/playlist/itml.c;h=5f636262f1b9248eaedb3dfce354592c946884fe;hb=HEAD
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170519/d40edeb1/attachment.html>