[vlc-devel] [PATCH 3/3] macOS: Use larger type for bookmark hours and minutes

[David Fuhrmann]

> Am 19.05.2017 um 17:50 schrieb Marvin Scholz <epirat07 at gmail.com>:
> 
> ---
> modules/gui/macosx/VLCBookmarksWindowController.m | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/modules/gui/macosx/VLCBookmarksWindowController.m b/modules/gui/macosx/VLCBookmarksWindowController.m
> index e3043b56fb..d690430975 100644
> --- a/modules/gui/macosx/VLCBookmarksWindowController.m
> +++ b/modules/gui/macosx/VLCBookmarksWindowController.m
> @@ -341,11 +341,11 @@ - (NSString *)timeStringForBookmark:(seekpoint_t *)bookmark
>     assert(bookmark != NULL);
> 
>     mtime_t total = bookmark->i_time_offset;
> -    unsigned hour = ( total / ( CLOCK_FREQ * 3600 ) );
> -    unsigned min = ( total % ( CLOCK_FREQ * 3600 ) ) / ( CLOCK_FREQ * 60 );
> +    uint64_t hour = ( total / ( CLOCK_FREQ * 3600 ) );
> +    uint64_t min = ( total % ( CLOCK_FREQ * 3600 ) ) / ( CLOCK_FREQ * 60 );
>     float    sec = ( total % ( CLOCK_FREQ * 60 ) ) / ( CLOCK_FREQ * 1. );
> 
> -    return [NSString stringWithFormat:@"%02d:%02d:%06.3f", hour, min, sec];
> +    return [NSString stringWithFormat:@"%02llu:%02llu:%06.3f", hour, min, sec];
> }
> 


Hi,

LGTM for the series.

BR. David