[vlc-devel] [PATCH 1/5] demux/playlist: itml: do not halt parsing on unsupported track

[Marvin Scholz]

On 21 May 2017, at 20:49, Filip Roséen wrote:

> This change makes it so that a track without <key>Location</key> is
> simply ignored, instead of it preventing further tracks within the
> playlist to be parsed (as we should of course import as many tracks as
> we possibly can, even if there are some we simply cannot handle).
> ---
>  modules/demux/playlist/itml.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/modules/demux/playlist/itml.c 
> b/modules/demux/playlist/itml.c
> index 5f636262f1..5a5eb3b048 100644
> --- a/modules/demux/playlist/itml.c
> +++ b/modules/demux/playlist/itml.c
> @@ -326,9 +326,9 @@ static bool parse_track_dict( demux_t *p_demux, 
> input_item_node_t *p_input_node,
>
>      if( !p_track->location )
>      {
> -        msg_Err( p_demux, "Track needs Location" );
> +        msg_Warn( p_demux, "ignoring track without Location entry" );
>          free_track( p_track );
> -        return false;
> +        return true;
>      }
>
>      msg_Info( p_demux, "Adding '%s'", p_track->location );
> -- 
> 2.13.0

LGTM, thanks!