[vlc-devel] [PATCH] vlc_es: use union in es_format_t

Francois Cartegnie fcvlcdev at free.fr
Mon May 22 14:59:14 CEST 2017


Le 22/05/2017 à 08:28, Steve Lhomme a écrit :
> For reference the original patch is this one
> https://patches.videolan.org/patch/14924/
> 

Breaks or creates UB on all existing code late setting fmt->i_codec
Usual pattern
es_format_Init(fmt, 0, 0)
fmt->i_codec = foo;

Even more fun with fmt from stack.

I guess from now breaking changes are acceptable when introduced on purpose.

Francois


More information about the vlc-devel mailing list