[vlc-devel] [PATCH 5/5] check_sed: improve compatibility of cleanup.

Sean McGovern gseanmcg at gmail.com
Wed May 31 14:31:18 CEST 2017

Hi Robert,

On May 30, 2017 19:56, "Robert Mourning" <robedmo.git at gmail.com> wrote:

Replaces curly brace expansion with explicit enumeration.
There exists at least one "sh" implementation which does not
support the curly-brace syntax in the removed line.

Also adds quotes around $tmp expansion, in case `pwd` contains spaces.

 extras/tools/bootstrap | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extras/tools/bootstrap b/extras/tools/bootstrap
index 19b08a2..1d0397e 100755
--- a/extras/tools/bootstrap
+++ b/extras/tools/bootstrap
@@ -34,7 +34,7 @@ fi

 check_sed() {
-trap "rm $tmp{,-e} 2>/dev/null" EXIT
+trap "rm \"$tmp\" \"$tmp-e\" 2>/dev/null" EXIT
 echo "test file for GNU sed" > $tmp
 if ! sed -i -e 's/sed//' $tmp >/dev/null 2>&1

vlc-devel mailing list
To unsubscribe or modify your subscription options:

I had always planned to revisit this chunk when I had a free moment. Thanks
for beating me to it.

LGTM to the change itself.

-- Sean McG.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170531/176a0c3c/attachment.html>

More information about the vlc-devel mailing list