[vlc-devel] [PATCH] vout: snapshot: fix snapshots cropping

Romain Vimont rom at rom1v.com
Fri Nov 3 12:09:35 CET 2017

Le vendredi  3 novembre 2017 à 12:52 +0200, Rémi Denis-Courmont a écrit :
> I don't know why picture copy does not copy the offsets (not to say
> that there is no reason).

Even if it did, in vout_snapshot_Set(), the picture has no offsets, they
are provided in a separate video_format_t parameter.

> But clone implies shallow copy.

I am not sure that "clone" implies shallow copy. IMO, it depends.

For instance, in C++, a "clone()" method usually calls the *copy*
constructor (it is just provided for polymorphism), which may deep- or

In Rust, the Clone trait is typically used to deep-copy an object.

I think that *clone* suggests that the copy is returned (contrary to

What name do you suggest instead?

> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list