[vlc-devel] [vlc-commits] configure: reenable -z,defs

[Thomas Guillem]

On Tue, Nov 7, 2017, at 18:05, Rémi Denis-Courmont wrote:
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Nov  7
> 18:45:12 2017 +0200| [e85682585ab27a3c0593c403b892190c52009960] |
> committer: Rémi Denis-Courmont
> 
> configure: reenable -z,defs
> 
> Because people can clearly not be trusted to build without it.

Which people ? "with_sanitizer" is disabled by default. I think most
devs don't use it for their everyday work.

The clang documentation about AddressSanitizer says that it shouldn't be
used.

See:
https://clang.llvm.org/docs/AddressSanitizer.html#usage
"When linking shared libraries, the AddressSanitizer run-time is not
linked, so -Wl,-z,defs may cause link errors (don’t use it with
AddressSanitizer). "

If I remember correctly, I already saw these undefined errors when I was
using clang on Linux.

> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e85682585ab27a3c0593c403b892190c52009960
> ---
> 
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 64576ed018..9e9571dea4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1133,7 +1133,7 @@ AC_CACHE_CHECK([if linker supports -z,defs],
> [ac_cv_ld_z_defs], [
>      ac_cv_ld_z_defs="no"
>    ])
>  ])
> -AS_IF([test "${ac_cv_ld_z_defs}" = "no" -o "${with_sanitizer}" != "no"],
> [VLC_RESTORE_FLAGS])
> +AS_IF([test "${ac_cv_ld_z_defs}" = "no"], [VLC_RESTORE_FLAGS])
>  
>  dnl Check for __attribute__((packed))
>  AC_CACHE_CHECK([for __attribute__((packed))],
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits