[vlc-devel] [PATCH 0/3] add add_submodule_name( with_a_name )

[Rémi Denis-Courmont]

Le 8 novembre 2017 12:28:13 GMT+02:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>
>On Tue, Nov 7, 2017, at 18:54, Rémi Denis-Courmont wrote:
>> Le tiistaina 7. marraskuuta 2017, 18.40.33 EET Thomas Guillem a écrit
>:
>> > Hello,
>> > 
>> > I know that we are in a FREEZING state and I don't like touching
>the CORE
>> > plugin API but this is the simplest and sanner way to fix this
>issue:
>> > https://trac.videolan.org/vlc/ticket/18896
>> > 
>> > I already encountered this kind of issue a number of time and
>always did
>> > some workaround to fix it. For this case, I don't have any. This
>new module
>> > call could also be very useful in the future.
>> > 
>> > And, on the plus side, it removes an Ugly comment, no ? ;)
>> 
>> We shouldn´t automatically set a name for submodules at all. But this
>> change 
>> looks too dangerous to me at this point.
>
>OK. For 4.0, should we change the argument of add_submodule() to
>specify
>a module name (or a shortcut list with the fist one being  the name ) ?
>
>> 
>> -- 
>> 雷米‧德尼-库尔蒙
>> https://www.remlab.net/
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

On second thoughts, I think all modules should specify their name explicitly.
-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.