[vlc-devel] [vlc-commits] configure: reenable -z,defs

[Thomas Guillem]

On Wed, Nov 8, 2017, at 12:16, Thomas Guillem wrote:
> 
> On Tue, Nov 7, 2017, at 19:35, Rémi Denis-Courmont wrote:
> > Le tiistaina 7. marraskuuta 2017, 19.07.49 EET Thomas Guillem a écrit :
> > > On Tue, Nov 7, 2017, at 19:04, Rémi Denis-Courmont wrote:
> > > > Le tiistaina 7. marraskuuta 2017, 18.58.44 EET Thomas Guillem a écrit :
> > > > > On Tue, Nov 7, 2017, at 18:05, Rémi Denis-Courmont wrote:
> > > > > > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Nov
> > > > > >  7
> > > > > > 18:45:12 2017 +0200| [e85682585ab27a3c0593c403b892190c52009960] |
> > > > > > committer: Rémi Denis-Courmont
> > > > > > 
> > > > > > configure: reenable -z,defs
> > > > > > 
> > > > > > Because people can clearly not be trusted to build without it.
> > > > > 
> > > > > Which people ? "with_sanitizer" is disabled by default. I think most
> > > > > devs don't use it for their everyday work.
> > > > 
> > > > I think devs should use sanitizers *and* -z,defs. I do.
> > > 
> > > Enabling -z,defs is working for me and for most of people here, so I
> > > don't have a strong opinions about that.
> > > 
> > > But it is what you think versus what clang recommends.
> > 
> > -z,defs is not my opinion, it is a requirement of distro policies.
> > 
> > All clang says is that you might get missing symbols if you don´t link
> > the 
> > sanitizer(s) explicitly because clang is too stupid to do it
> > automatically.
> 
> This breaks link with GCC 7.2 on fedora with -width-sanitizer=address.
> It seems both gcc or clang can be too stupid.

Same problem with GCC 6.3 on Debian stable.

I really want to add it back.

> 
> 
> > 
> > -- 
> > 雷米‧德尼-库尔蒙
> > https://www.remlab.net/
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel