[vlc-devel] [vlc-commits] configure: reenable -z,defs

[Rémi Denis-Courmont]

Le 10 novembre 2017 13:28:41 GMT+02:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>> 
>> Works fine on Debian with GCC 6 and 7.
>
>Not with the --with-sanitizer command line.
>
>Should we add -lasan in LDFLAGS if the CC is gcc ?
>
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser
>> ma brièveté.
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

It is the responsibility of the configure caller to pass consistent parameters. We are not going to fix up broken or incomplete sets.

Repeating myself, but -with-sanitizer seems pretty pointless given that the possible sets of combined sanitizers and their respective constraints are heavily platform and compiler version-specific.

In reality, anyone reasonable has a wrapper script to run configure with whatever parameters they need anyway.
-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.