[vlc-devel] [PATCH] gui/qt: bookmarks: fix psz_name lifetime

Filip Roséen filip at atch.se
Fri Nov 10 20:10:36 CET 2017

Hi Romain,

On 2017-11-10 19:08, Romain Vimont wrote:

> Le vendredi 10 novembre 2017 à 17:04 +0100, Filip Roséen a écrit :
> > I agree with what you write (in terms of behavior), but the relevant
> > piece of implementation should go through a more robust clean-up than
> > what you propose
> Do you suggest to completely remove the qtu() macro?

No, I was referring to the *bookmark-keeping* when I mentioned *"more
robust clean-up"*, and not only in `modules/gui/qt`

The `qtu` macro might not be the safest of them all, but given that
the only case I can find where it is being used in the wrong way (I
just gave a quick skim over every usage) is the issue you brought up,
I do not think it is of any major importance to remove it right now.

Would I rest a little easier knowing that `qtu` was replaced by a
safer alternative? Surely. However, do I also feel that it should be
on the priority list at the current time? No.

Best Regards,\
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20171110/c3353b18/attachment.html>

More information about the vlc-devel mailing list