[vlc-devel] [PATCH] configure.ac: unbreak AM_ICONV tests with -lasan

[Rémi Denis-Courmont]

Le tiistaina 14. marraskuuta 2017, 16.58.36 EET Thomas Guillem a écrit :
> On Tue, Nov 14, 2017, at 16:52, Rémi Denis-Courmont wrote:
> > Le tiistaina 14. marraskuuta 2017, 16.38.54 EET Francois Cartegnie a
> > 
> > écrit :
> > > if -lasan needs to go through LDFLAGS because
> > > of -zdefs then iconv test cannot survive again
> > 
> > Sorry but this is utter BS.
> > 
> > The iconv test is performed before sanitizers are enabled, so it cannot
> > be
> > affected by asan linking issues.
> 
> If you have a broken libtool (like almost everyone since there is no
> release since the fix was pushed), you have to force extra flags:
> LDFLAGS="-lasan" when running configure.

That bug has nothing to do with the iconv test whatsoever, and thus this patch 
does *not* work around that bug.

BTW, I only have the libtool issue with linking C++ (Debian Sid), and the 
iconv test is pure C...

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/