[vlc-devel] [PATCH] configure.ac: unbreak AM_ICONV tests with -lasan

[Hugo Beauzée-Luyssen]

On Tue, Nov 14, 2017, at 05:37 PM, Hugo Beauzée-Luyssen wrote:
> 
> 
> On Tue, Nov 14, 2017, at 05:08 PM, Rémi Denis-Courmont wrote:
> > Le tiistaina 14. marraskuuta 2017, 16.58.36 EET Thomas Guillem a écrit :
> > > On Tue, Nov 14, 2017, at 16:52, Rémi Denis-Courmont wrote:
> > > > Le tiistaina 14. marraskuuta 2017, 16.38.54 EET Francois Cartegnie a
> > > > 
> > > > écrit :
> > > > > if -lasan needs to go through LDFLAGS because
> > > > > of -zdefs then iconv test cannot survive again
> > > > 
> > > > Sorry but this is utter BS.
> > > > 
> > > > The iconv test is performed before sanitizers are enabled, so it cannot
> > > > be
> > > > affected by asan linking issues.
> > > 
> > > If you have a broken libtool (like almost everyone since there is no
> > > release since the fix was pushed), you have to force extra flags:
> > > LDFLAGS="-lasan" when running configure.
> > 
> > That bug has nothing to do with the iconv test whatsoever, and thus this
> > patch 
> > does *not* work around that bug.
> > 
> > BTW, I only have the libtool issue with linking C++ (Debian Sid), and the 
> > iconv test is pure C...
> > 
> 
> That's irrelevan. The test fails because a leak is found, not because of
> a compilation error.
> 
> AFAICS, our options include:
> - Having a new libtool version released (have fun)
> - Having no subtitles in asan builds (unacceptable IMHO)
> - Specifying ASAN_OPTIONS=exitcode=0 for the entire configure process
> 
> For future reference, currently released libtool versions are missing
> this commit:
> http://git.savannah.gnu.org/cgit/libtool.git/commit/?id=a5c6466528c060cc4660ad0319c00740db0e42ba
> 

Oh and FWIW, while I'd like to go with option one, I think the 3rd one
is the best one for now.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr