[vlc-devel] [PATCH] m4: fix false negative working iconv test

[Hugo Beauzée-Luyssen]

On Tue, Nov 14, 2017, at 06:00 PM, Rémi Denis-Courmont wrote:
> Part of the test is leaking memory, which can trip the leak sanitizer.
> 
> (This should be fixed in gettext. In the mean time, it will need to be
>  applied manually at every gettext update.)
> ---
>  m4/iconv.m4 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/m4/iconv.m4 b/m4/iconv.m4
> index 4e37363156..53a6b3b0c2 100644
> --- a/m4/iconv.m4
> +++ b/m4/iconv.m4
> @@ -165,6 +165,7 @@ AC_DEFUN([AM_ICONV_LINK],
>        }
>    }
>  #endif
> +#if 0 /* This test leaks and we do not care about HP-UX. */
>    /* Test against HP-UX 11.11 bug: No converter from EUC-JP to UTF-8 is
>       provided.  */
>    if (/* Try standardized names.  */
> @@ -176,6 +177,7 @@ AC_DEFUN([AM_ICONV_LINK],
>        /* Try HP-UX names.  */
>        && iconv_open ("utf8", "eucJP") == (iconv_t)(-1))
>      result |= 16;
> +#endif
>    return result;
>  ]])],
>            [am_cv_func_iconv_works=yes], ,
> -- 
> 2.15.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

Assuming the (original) comment is correct and is only meant to work
around an issue in HP-UX, LGTM.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr