[vlc-devel] [PATCH] hxxx: move the common H26x NAL parsing code in a common static library

Thomas Guillem thomas at gllm.fr
Fri Nov 17 08:47:06 CET 2017



On Fri, Nov 17, 2017, at 08:34, Steve Lhomme wrote:
> On Thu, Nov 16, 2017 at 8:44 PM, Rémi Denis-Courmont <remi at remlab.net>
> wrote:
> > TBH, I don't really see the point of all these changes. If the library is static, then the code is still duplicated in the final output binary. And C code is not that slow to compile - unlike C++. In fact, if LTO is enabled, this saves almost nothing at all, since compilation is done in linker phase.
> 
> The original idea is to enable static builds. Having the same file
> compiled many times in the same output binary is not good.
> And it helps with the compile time a parallelization a bit too. That's a
> bonus.
> 

And it's way cleaner that way, no ? It also avoids dirty hackers to
build these files with different defines ;) (ok, sometimes, it's
convenient)

> > --
> > Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list