[vlc-devel] [PATCH] skin2: fix string can't be parsed by gettext

[Rémi Denis-Courmont]

Le keskiviikkona 22. marraskuuta 2017, 14.30.49 EET Pierre Lamot a écrit :
>   fix: #19117
> ---
>  modules/gui/skins2/src/dialogs.cpp | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/gui/skins2/src/dialogs.cpp
> b/modules/gui/skins2/src/dialogs.cpp index 79885ea5d8..275d7c3f96 100644
> --- a/modules/gui/skins2/src/dialogs.cpp
> +++ b/modules/gui/skins2/src/dialogs.cpp
> @@ -210,9 +210,10 @@ void Dialogs::showChangeSkin()
> 
>  void Dialogs::showPlaylistLoad()
>  {
> +    char fileTypes[256];

What could possibly go wrong? You know C++ has a string class...

> +    snprintf(fileTypes, sizeof(fileTypes), _("Playlist Files|%s|All
> Files|*") , EXTENSIONS_PLAYLIST ); showFileGeneric( _("Open playlist"),
> -                     _("Playlist Files|" EXTENSIONS_PLAYLIST "|"
> -                       "All Files|*"),
> +                     fileTypes,
>                       showPlaylistLoadCB, kOPEN );
>  }

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/