[vlc-devel] [PATCH] fix abort (crash) if EPG string is not UTF8
Abylay Ospan
aospan at netup.ru
Wed Nov 22 17:56:19 CET 2017
Great ! I see your commits. Now vlc doesn't abort on this TS dump. Thanks !
P.S.
but i have noticed that last symbol in all EPG program names is lost.
Please check screenshot here:
https://drive.google.com/file/d/1lHeeMicqQQA4LrMoPpVrIJuvrsnaKfS8/view?usp=sharing
seems like '4523786e48364d4d9b5bb3b69e596058160b8ae9' introduced this problem.
2017-11-22 9:08 GMT-05:00 Francois Cartegnie <fcvlcdev at free.fr>:
> Le 21/11/2017 à 20:55, Abylay Ospan a écrit :
>> Agree. My original patch not fixing root cause of this problem. Below is
>> more details and sample. Need to decide what the best way to fix this
>> problem and I will try to fix. Should we convert all EIT strings to UTF-8 ?
>> If yes then possibly somewhere in libdvbpsi (as it may obtain character
>> set) ?
>> As I understand vlc GUI accept only UTF8 strings, right ?
>> How does it work now and how it should work (correct) ?
>>
>>
>> --- additional details
>>
>> TS Sample (54MB). This is ATSC full TS dump. Obtained in Miami, FL,
>> USA. 671Mhz. just run latest vlc with this file to see the problem.
>>
>> https://drive.google.com/file/d/10HwVhyXk6TQK5-s60FnlZcircJ0_9tc7/view?usp=sharing
>>
>> backtrace and hexdump of psz_val below. It contains "Abismo de pasión"
>> where symbol "ó" is 0xF3 (for example in windows-1252 charset).
>
> Has been fixed.
>
> thanks
>
> --
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
--
Abylay Ospan,
NetUP Inc.
http://www.netup.tv
More information about the vlc-devel
mailing list