[vlc-devel] [PATCH] [RFC] configure: force WINNT_VERSION to 0x601 through -D

[Steve Lhomme]

On Thu, Nov 30, 2017 at 9:02 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>
>
> On Thu, 30 Nov 2017, at 09:01, Steve Lhomme wrote:
>> This patch may break UWP builds though as the set of APIs is forced in
>> the command line.
>
> For UWP, you should probably stay on the 3.0 branch.

Yes.

A proper way to handle this might be to add a configure option to set
the Windows API you want. And fallback to 0x601 if it's not set.

>>
>> On Thu, Nov 30, 2017 at 8:58 AM, Steve Lhomme <robux4 at gmail.com> wrote:
>> > On Thu, Nov 30, 2017 at 3:06 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>> >> What I don't get is why this is necessary, since it's already defined in
>> >> AH_TOP.
>> >
>> > It's added to the config.h but it's not used during configure so you
>> > still configure for a different set of APIs.
>> >
>> >> But else, it does not work for pollfd and inet_pton detection
>> >> ---
>> >>  configure.ac | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/configure.ac b/configure.ac
>> >> index c7360021f4..bb679caad2 100644
>> >> --- a/configure.ac
>> >> +++ b/configure.ac
>> >> @@ -536,7 +536,7 @@ dnl Check for broken versions of mingw-runtime compatability library
>> >>      ])
>> >>
>> >>      dnl force use of mingw provided c99 *printf over msvcrt
>> >> -    CPPFLAGS="${CPPFLAGS} -D__USE_MINGW_ANSI_STDIO=1"
>> >> +    CPPFLAGS="${CPPFLAGS} -D__USE_MINGW_ANSI_STDIO=1 -D_WIN32_WINNT=0x601"
>> >>
>> >>      dnl Check for the need to include the mingwex lib for mingw32
>> >>      VLC_SAVE_FLAGS
>> >> --
>> >> 2.15.0.531.g2ccb3012c9
>> >>
>> >> _______________________________________________
>> >> vlc-devel mailing list
>> >> To unsubscribe or modify your subscription options:
>> >> https://mailman.videolan.org/listinfo/vlc-devel
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>
> --
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel