[vlc-devel] [PATCH 1/2] configure: Do not use -no-undefined with sanitizers on darwin

[Rémi Denis-Courmont]

Le torstaina 5. lokakuuta 2017, 17.02.15 EEST Marvin Scholz a écrit :
> What you wrote in the past was:
> 
> "If you really want to make sanitizers easy to use, then add an option
> to
> enable them, like we do for coverage. Not this patch, please."
> 
> This is now the case, except without this patch when enabling the
> sanitizer,
> I get linker errors on macOS due to the -no-undefined flag.

I think that I also mentioned that missing symbols can be fixed by fixing 
linker flags manually (though it is obviously preferable to fix the compiler 
scripts).

You are removing a proven sanity check without any rationale why it would no 
longer be relevant. I also don't see how sanitizers are a MacOS-specific 
problem.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/