[vlc-devel] X265 contrib link error against master generation

[Rémi Denis-Courmont]

Le perjantaina 6. lokakuuta 2017, 21.00.53 EEST Gilles Sabourin a écrit :
> So I have a look at vlc master tree and I found this commit:
> 
> 
> Author: Hugo Beauzée-Luyssen <hugo at beauzee.fr>
> Date:   Mon Sep 18 10:22:52 2017 +0200
> 
>     modules: x265 is a C++ module
> 
> diff --git a/modules/codec/Makefile.am b/modules/codec/Makefile.am
> index 10eb160d36..da49a0704f 100644
> --- a/modules/codec/Makefile.am
> +++ b/modules/codec/Makefile.am
> @@ -475,9 +475,9 @@ endif
> 
>  ### X26x encoders ###
> 
> -libx265_plugin_la_SOURCES = codec/x265.c
> +libx265_plugin_la_SOURCES = codec/x265.c dummy.cpp
>  libx265_plugin_la_CPPFLAGS = $(AM_CPPFLAGS)
> -libx265_plugin_la_CFLAGS = $(AM_CFLAGS) $(CFLAGS_x265)
> +libx265_plugin_la_CXXFLAGS = $(AM_CFLAGS) $(CFLAGS_x265)
>  libx265_plugin_la_LDFLAGS = $(AM_LDFLAGS) $(LDFLAGS_x265) -rpath '$
> (codecdir)'
>  libx265_plugin_la_LIBADD = $(LIBS_x265)
>  EXTRA_LTLIBRARIES += libx265_plugin.la
> 
> I reverted it and I was able to link successfully with x265. I think this
> commit is wrong : x265 team has developed his library using C++, but this
> does not imply that their API is only reachable using C++...

Confirmed and fixed, thanks for the report.

In fact x265 is already doing the right thing internally - exposing stdc++ as 
a dependency in pkg-config.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/