[vlc-devel] [PATCH] tls: fix ignored interrupts

Thomas Guillem thomas at gllm.fr
Wed Oct 11 18:24:32 CEST 2017



On Wed, Oct 11, 2017, at 18:15, Rémi Denis-Courmont wrote:
> Le tiistaina 10. lokakuuta 2017, 13.06.07 EEST Thomas Guillem a écrit :
> > If session->readv() or session->writev() are interrupted, the next call to
> > vlc_poll_i11e() will hang since the interrupt context is already finished
> > (by readv/writev).
> 
> In principles, ->readv/writev are non-blocking, so I´m not sure why they
> even 
> check&reset interrupt status... ?

It's true for readv() (so this part can be reverted) but not for writev:

sock->writev is set to vlc_tls_ConnectWrite from
vlc_tls_SocketOpenAddrInfo().

And vlc_tls_ConnectWrite() can call vlc_tls_WaitConnect() that call
vlc_poll_i11e().

> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list