[vlc-devel] [RFC] [PATCH 1/2] demux: adaptive: fix cancellation during refresh playlist

[Zhao Zhili]

Hi jb,

I have resent this patch as:

[vlc-devel] [PATCH 3/6] demux: adaptive: fix cancellation during refresh playlist
https://mailman.videolan.org/pipermail/vlc-devel/2017-September/115538.html

I don't known if there anything I can do to improve the patch or just give up.

> On 13 Oct 2017, at 6:58 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> 
> This is still a concern?
> 
> 
> On Tue, 12 Sep 2017, at 23:46, Zhao Zhili wrote:
>> 
>> This patch fixed a crash due to assert failure since mutex is not
>> unlocked before vlc_mutex_destroy().
>> ---
>>  modules/demux/adaptive/PlaylistManager.cpp | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/modules/demux/adaptive/PlaylistManager.cpp 
>> b/modules/demux/adaptive/PlaylistManager.cpp
>> index 3ee5014..706ece0 100644
>> --- a/modules/demux/adaptive/PlaylistManager.cpp
>> +++ b/modules/demux/adaptive/PlaylistManager.cpp
>> @@ -633,10 +633,12 @@ void PlaylistManager::Run()
>> 
>>          if(needsUpdate())
>>          {
>> +            int canc = vlc_savecancel();
>>              if(updatePlaylist())
>>                  scheduleNextUpdate();
>>              else
>>                  failedupdates++;
>> +            vlc_restorecancel(canc);
>>          }
>> 
>>          vlc_mutex_lock(&demux.lock);
>> -- 
>> 2.7.4
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> Email had 1 attachment:
>> + 0001-demux-adaptive-fix-cancellation-during-refresh-playl.patch
>>  1k (text/x-patch)
> 
> 
> -- 
> Jean-Baptiste Kempf -  President
> +33 672 704 734
>