[vlc-devel] [PATCH 1/2] videotoolbox: Handle kVTParameterErr as error

[Thomas Guillem]

Looks good to me. Is it related to #18925 ? (Could you mention it plz ?)

On Mon, Oct 16, 2017, at 00:18, Marvin Scholz wrote:
> Previously kVTParameterErr was not indicated as an error but as
> VTSESSION_STATUS_OK in HandleVTStatus.
> ---
>  modules/codec/videotoolbox.m | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/modules/codec/videotoolbox.m b/modules/codec/videotoolbox.m
> index 7b4524566c..d406ac54bf 100644
> --- a/modules/codec/videotoolbox.m
> +++ b/modules/codec/videotoolbox.m
> @@ -1329,6 +1329,7 @@ static int HandleVTStatus(decoder_t *p_dec,
> OSStatus status,
>          switch (status)
>          {
>              case -8960 /* codecErr */:
> +            case kVTParameterErr:
>              case kCVReturnInvalidArgument:
>              case kVTVideoDecoderMalfunctionErr:
>                  *p_vtsession_status = VTSESSION_STATUS_ABORT;
> -- 
> 2.13.5 (Apple Git-94)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel