[vlc-devel] [RFC] [PATCH] configure: Remove call to private _AM_DEPENDENCIES

[Thomas Guillem]

Ok for me.

On Mon, Oct 16, 2017, at 11:38, Marvin Scholz wrote:
> On 16 Oct 2017, at 11:04, Rémi Denis-Courmont wrote:
> 
> > Le 16 octobre 2017 10:38:41 GMT+02:00, Marvin Scholz 
> > <epirat07 at gmail.com> a écrit :
> >> _AM_DEPENDENCIES is a private macro, according to the documentation 
> >> it
> >> should not be called directly. In this case, _AM_DEPENDENCIES should
> >> already be called by AC_PROG_OBJC.
> >> ---
> >> If this is necessary for some reason, we probably should add at least
> >> add a comment explaining the reason for its use.
> >>
> >> configure.ac | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index 19f80b8608..066c63edcb 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -61,7 +61,6 @@ AM_PROG_CC_C_O
> >> AC_PROG_CXX
> >> AC_PROG_CPP
> >> AC_PROG_OBJC
> >> -_AM_DEPENDENCIES([OBJC])
> >> AC_PROG_EGREP
> >> AC_PROG_MAKE_SET
> >> AC_PROG_INSTALL
> >> -- 
> >> 2.13.5 (Apple Git-94)
> >>
> >> _______________________________________________
> >> vlc-devel mailing list
> >> To unsubscribe or modify your subscription options:
> >> https://mailman.videolan.org/listinfo/vlc-devel
> >
> > the reason should be trackable w/ git-blame
> 
> I've checked and I could not find a reason. I guess at the point of time
> it was added, AC_PROG_OBJC did not exist yet, as some other ways to 
> detect
> the Objective C compiler were used when _AM_DEPENDENCIES was added.
> 
> I suspect it was just never removed again after configure.ac was updated 
> to
> use the AC_PROG_OBJC macro.
> 
> > -- 
> > Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
> > excuser ma brièveté.
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel