[vlc-devel] [PATCH] Fixed crash when getting statistics on uninitalized media

[Rémi Denis-Courmont]

On mercredi 18 octobre 2017 10:58:00 EEST Jérémy VIGNELLES wrote:
> ---
>  lib/media.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/media.c b/lib/media.c
> index 8da5a130e2..fcfdcd702b 100644
> --- a/lib/media.c
> +++ b/lib/media.c
> @@ -698,7 +698,7 @@ libvlc_media_subitems( libvlc_media_t * p_md )
>  int libvlc_media_get_stats( libvlc_media_t *p_md,
>                              libvlc_media_stats_t *p_stats )
>  {
> -    if( !p_md->p_input_item )
> +    if( !p_md->p_input_item || !p_md->p_input_item->p_stats )
>          return false;
> 
>      input_stats_t *p_itm_stats = p_md->p_input_item->p_stats;

This does not look thread-safe to me.

-- 
Rémi Denis-Courmont