[vlc-devel] [PATCH] iconv: add local ISO_6937-2 conversion

[Salah-Eddin Shaban]

On Wed, Oct 18, 2017 at 7:52 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le keskiviikkona 18. lokakuuta 2017, 19.41.01 EEST Salah-Eddin Shaban a
> écrit :
>> And use our local conversion on all platforms.
>
> No thanks.
>

ISO_6937 conversion was added to vlc because it was required for EPG.
ISO_6937-2 is being added now because it's required for EBU subtitles.
Both of these use supersets of the standard (the Euro sign in the case
of EPG, and Addendum 1-1989 in the case of EBU STL). Without them our
implementation is not complete. Worse still, a single character
erroneously identified as invalid causes the whole string to fail
conversion.

We could still use iconv for these conversions on platforms that
support it, but then FromCharset would be unusable, because we have to
watch for errors other than E2BIG to catch invalid input characters
and check whether or not they are among the extra ones we have to
handle.