[vlc-devel] [PATCH v2 2/3] qt: send mouse release events before popping a QMenu to avoid Vout mouse state corruption

[pierre]

On Friday, October 27, 2017 7:38:34 PM CEST Rémi Denis-Courmont wrote:
> Le perjantaina 27. lokakuuta 2017, 18.29.43 EEST Pierre Lamot a écrit :
> > ---
> > 
> >  modules/gui/qt/dialogs_provider.cpp |  5 +++++
> >  modules/gui/qt/dialogs_provider.hpp |  1 +
> >  modules/gui/qt/main_interface.cpp   | 25 +++++++++++++++++++++++++
> >  modules/gui/qt/main_interface.hpp   |  1 +
> >  4 files changed, 32 insertions(+)
> 
> I am rather suspicious with how that will work with non-embedded windows...

With non-embedded windows, qt doesn't grab mouse events related to that 
window. so no duplicate release events is sent to the vout.

Though, there is another problem with non-embeded windows (at least with X11). 
the menu is destroyed as soon as it is created. The windows re-takes the focus 
instantly or somethings like that (haven't found the root cause yet), which 
detroys the menu.

-- 
Pierre Lamot