[vlc-devel] [PATCH] [WIP] RFC: add HDR/BT.2020 support (using libplacebo)

[Marvin Scholz]

On 30 Oct 2017, at 13:18, Thomas Guillem wrote:

> On Fri, Oct 27, 2017, at 14:45, Niklas Haas wrote:
>> On Fri, 27 Oct 2017 02:37:08 +0200, Niklas Haas <vlc at haasn.xyz> 
>> wrote:
>>> On Thu, 26 Oct 2017 20:01:07 +0300, Rémi Denis-Courmont 
>>> <remi at remlab.net> wrote:
>>>> VLC has its own convenience wrapper for that. Obviously, that 
>>>> can´t be used
>>>> for by an external library. But you can use a similar solution.
>>>>
>>>
>>> I've given the solution an attempt:
>>> https://github.com/haasn/libplacebo/commit/0e67eec23628f97089bb25724248e502694c57bb
>>>
>>> This works on my end, but currently only has an implementation for
>>> systems with `uselocale`, which apparently Win32 does not belong to. 
>>> On
>>> Win32, there are locale-invariant versions of printf which could be 
>>> used
>>> to implement the same API, but I'm unable to produce this code. (BSD
>>> could also use the printf_l etc. wrappers, although BSD supports
>>> uselocale so it shouldn't be necessary)
>>
>> I've also updated my patch in order to incorporate integration with 
>> the
>> build system + contrib/ (thanks to ePirat for the code), and make the
>> code optional (based on #ifdef HAVE_LIBPLACEB).
>>
>> I've attached the new version.
>
> - You should do a new commit for the contrib part.

This was already a separate commit, I advised squashing all into one 
commit
is not a good idea.

>
> - You should split the additions of glUniformMatrix* in the vtable in 
> a
> new commit.
>
> - The configure.ac has one error that triggers an error when placebo 
> is
> not found and not forced. It should also use AS_HELP_STRING. Here is 
> the
> diff: 
> https://gist.github.com/tguillem/a86efe451ba63b241967ecf1fee9903f

Indeed, thanks!

>
>
> Otherwise, it looks fine to me.
>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> Email had 1 attachment:
>> + 0001-video_output-opengl-add-basic-support-for-libplacebo.patch
>>   20k (text/plain)
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel