[vlc-devel] [PATCH] [WIP] RFC: add HDR/BT.2020 support (using libplacebo)
epirat07 at gmail.com
Mon Oct 30 13:27:57 CET 2017
On 30 Oct 2017, at 13:18, Thomas Guillem wrote:
> On Fri, Oct 27, 2017, at 14:45, Niklas Haas wrote:
>> On Fri, 27 Oct 2017 02:37:08 +0200, Niklas Haas <vlc at haasn.xyz>
>>> On Thu, 26 Oct 2017 20:01:07 +0300, Rémi Denis-Courmont
>>> <remi at remlab.net> wrote:
>>>> VLC has its own convenience wrapper for that. Obviously, that
>>>> can´t be used
>>>> for by an external library. But you can use a similar solution.
>>> I've given the solution an attempt:
>>> This works on my end, but currently only has an implementation for
>>> systems with `uselocale`, which apparently Win32 does not belong to.
>>> Win32, there are locale-invariant versions of printf which could be
>>> to implement the same API, but I'm unable to produce this code. (BSD
>>> could also use the printf_l etc. wrappers, although BSD supports
>>> uselocale so it shouldn't be necessary)
>> I've also updated my patch in order to incorporate integration with
>> build system + contrib/ (thanks to ePirat for the code), and make the
>> code optional (based on #ifdef HAVE_LIBPLACEB).
>> I've attached the new version.
> - You should do a new commit for the contrib part.
This was already a separate commit, I advised squashing all into one
is not a good idea.
> - You should split the additions of glUniformMatrix* in the vtable in
> new commit.
> - The configure.ac has one error that triggers an error when placebo
> not found and not forced. It should also use AS_HELP_STRING. Here is
> Otherwise, it looks fine to me.
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> Email had 1 attachment:
>> + 0001-video_output-opengl-add-basic-support-for-libplacebo.patch
>> 20k (text/plain)
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel