[vlc-devel] [vlc-commits] netconf: Don't ignore posix_spawn_* errors

[Rémi Denis-Courmont]

Le maanantaina 30. lokakuuta 2017, 17.32.55 EET Hugo Beauzée-Luyssen a écrit :
> On Mon, Oct 30, 2017, at 05:30 PM, Rémi Denis-Courmont wrote:
> > Le maanantaina 30. lokakuuta 2017, 16.11.40 EET Hugo Beauzée-Luyssen a
> > 
> > écrit :
> > > vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Tue Oct
> > > 24
> > > 16:43:55 2017 +0200| [11cd9c27beb5614c5923c78429c37b8db1237d9a] |
> > > committer: Hugo Beauzée-Luyssen
> > > 
> > > netconf: Don't ignore posix_spawn_* errors
> > 
> > I don't know any OS where those functions can actually fail (same
> > argument as
> > pthread_mutex_init, really). And then this patch is totally inconsistent
> > in
> > what it "fixes" and what it leaves as is.
> 
> I wrote this while tracking a crash on PPAPI/NaCl, though granted, this
> didn't fixed it.
> I just felt like since the error checking code was written, might as
> well commit it, but I'm fine with this being reverted if need be.

I would rather be consistent either way, and this is not.

Also, I fear that complete error handling will be awful (and totally untested/
untestable). I´d argue for abort() if you really want to check errors.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/