[vlc-devel] [PATCH] access/http: Fail for ICY, legacy HTTP module to retries

[Marvin Scholz]

On 29 Oct 2017, at 13:29, Rémi Denis-Courmont wrote:

> Le sunnuntaina 29. lokakuuta 2017, 13.14.22 EET Marvin Scholz a écrit :
>> Failing for ICY, the old HTTP module will retry and use the initially
>> provided URL, so auth information provided by the user in the URL is
>> not discarded.
>> ---
>>  modules/access/http/access.c   | 10 ++++++++++
>>  modules/access/http/resource.c |  6 ------
>>  2 files changed, 10 insertions(+), 6 deletions(-)
>>
>> diff --git a/modules/access/http/access.c b/modules/access/http/access.c
>> index ab72107a04..9a214bf03f 100644
>> --- a/modules/access/http/access.c
>> +++ b/modules/access/http/access.c
>> @@ -37,6 +37,7 @@
>>  #include "resource.h"
>>  #include "file.h"
>>  #include "live.h"
>> +#include "message.h"
>
> Layer violation. Nack.
>

Indeed. What would be a better way to do this without a layer violation?
I couldn't really come up with a good way, I am not very familiar with the
code, so I don't know what you would consider an acceptable solution.

> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel