[vlc-devel] Direct3d9 orientation

[Salah-Eddin Shaban]

Hello Remi, everyone

I'm trying to fix the orientation issue in direct3d9.

As Remi explained in a previous discussion:
https://mailman.videolan.org/pipermail/vlc-devel/2017-February/111520.html
I have modified direct3d9.c accordingly. The png-orient option was
added for testing, and I'm comparing results against the opengl vout.

Results are identical except for ORIENT_LEFT_BOTTOM and
ORIENT_RIGHT_TOP. As an example, after applying the patches:

https://drive.google.com/file/d/0B36ioujDBJZsSjRYcV9YZFMxNFk/view

The VLC instance on the left is: vlc --vout=opengl
lua\http\images\buttons.png --png-orient=5
The one on the right is the same except for --vout=direct3d9, and the
image on the bottom is the original.

So the orientation here is set to ORIENT_LEFT_BOTTOM. If I'm getting
this correctly this means the top line displayed by VLC should be the
left column of the original image, and the left column displayed by
VLC should be the bottom line of the original. So it seems to me the
direct3d9 vout has the correct result.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-png-add-png-orient-option.patch
Type: application/octet-stream
Size: 1005 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20171031/86644c83/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-direct3d9-fix-orientation.patch
Type: application/octet-stream
Size: 3021 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20171031/86644c83/attachment-0001.obj>