[vlc-devel] [PATCH] configure: Pass the macosx deps even if the intl to try is external

[Rémi Denis-Courmont]

On samedi 2 septembre 2017 14:37:52 EEST David Fuhrmann wrote:
> > Am 08.02.2017 um 18:39 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> > 
> > Le keskiviikkona 8. helmikuuta 2017, 16.31.32 EET Luca Barbato a écrit :
> >> We build our own copy, gettext.m4 did not account this corner case.
> > 
> > gettext.m4 is installed by bootstrap. You can´t patch it.
> > 
> > Obvious nack.
> 
> Hi all,
> 
> Looks like we actually fixed the problem with the same patch already in the
> past (for VLC 2.2 or earlier), see commit
> d879f020aee800abaafae2e333be6da6604a3577 in vlc.git.

You make it sound like the code was already patched but the patch was mever 
submitted upstream. Then it should not be surprising that it keeps breaking.

That or the patch is a work-around for a bug somewhere else in VLC that 
upstream won't accept.

> As discussed, we should be aware that it would get overwritten again once
> someone updates the m4 macros to a newer gettext version. So the only
> proper way to fix it seems to try to upstream that patch to the official
> gettext.

As far as I understand the documentation, autopoint should overwrite the files  
everytime bootstrap is called (through autoreconf), assuming that the matching 
Gettext version is available on the build system. When exactly autopoint 
*actually* overwrites the files, I do not know though that is ostensibly not 
as systematic as the documentation seems to imply. Maybe I don't understand 
the documentatiom.

In the older past, I recall that we have had problems with accidental updates 
to those files though. And we know for sure that this is bound to fail sooner 
or later though.

-- 
Rémi Denis-Courmont